Added validation for seed password#3783
Open
NathanDrake007 wants to merge 1 commit intohatchet-dev:mainfrom
Open
Added validation for seed password#3783NathanDrake007 wants to merge 1 commit intohatchet-dev:mainfrom
NathanDrake007 wants to merge 1 commit intohatchet-dev:mainfrom
Conversation
|
@NathanDrake007 is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
gregfurman
requested changes
May 4, 2026
Comment on lines
+22
to
+24
| if !validator.ValidatePassword(dc.Seed.AdminPassword) { | ||
| return fmt.Errorf("ADMIN_PASSWORD does not meet requirements: must be between 8 and 64 characters and contain at least one uppercase letter, one lowercase letter, and one number") | ||
| } |
Collaborator
There was a problem hiding this comment.
While this is technically valid, I'm thinking that we should rather just return a DefaultValidator and pass in an anonymous struct with a password field i.e
validator := validator.NewDefaultValidator()
opts := struct{Password string `json:"password"`}{dc.Seed.AdminPassword}
// Or maybe even just use the already existing CreateUserOpts 👇
// opts := repository.CreateUserOpts{Password: dc.Seed.AdminPassword}
err := validator.Validate(opts)
// ...That way we don't have to expose this function publicly and can just rely on our normal validation mechanism for this check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the seed job accepting any value for ADMIN_PASSWORD without validation, which resulted in an admin account that could not be used to log in. The seed job now rejects passwords that don't meet complexity requirements before hashing and writing to the database.
Fixes #3711
Type of change
What's Changed